Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max proposal code size docstring #3846

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix max proposal code size docstring #3846

merged 1 commit into from
Sep 26, 2024

Conversation

brentstone
Copy link
Collaborator

Describe your changes

The param is in bytes, not kB

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.03%. Comparing base (f88c4b9) to head (d79dd66).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3846   +/-   ##
=======================================
  Coverage   73.02%   73.03%           
=======================================
  Files         340      340           
  Lines      104816   104816           
=======================================
+ Hits        76543    76553   +10     
+ Misses      28273    28263   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 26, 2024
@mergify mergify bot merged commit e228667 into main Sep 26, 2024
23 of 24 checks passed
@mergify mergify bot deleted the brent/fix-docstring-gov branch September 26, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants