Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max proposal code size docstring #3846

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix max proposal code size docstring #3846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/apps_lib/src/client/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ pub async fn query_protocol_parameters(
);
display_line!(
context.io(),
"{:4}Max. proposal code size: {} kB",
"{:4}Max. proposal code size: {} bytes",
"",
max_proposal_code_size
);
Expand Down
2 changes: 1 addition & 1 deletion crates/apps_lib/src/config/genesis/templates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ pub struct PosParams {
pub struct GovernanceParams {
/// Min funds to stake to submit a proposal
pub min_proposal_fund: u64,
/// Maximum size of proposal in kibibytes (KiB)
/// Maximum size of proposal in bytes
pub max_proposal_code_size: u64,
/// Minimum number of epochs between the proposal end epoch and start epoch
pub min_proposal_voting_period: u64,
Expand Down
2 changes: 1 addition & 1 deletion crates/governance/src/parameters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use super::storage::keys as goverance_storage;
pub struct GovernanceParameters {
/// Minimum amount of locked funds
pub min_proposal_fund: token::Amount,
/// Maximum kibibyte length for proposal code
/// Maximum length for proposal code in bytes
pub max_proposal_code_size: u64,
/// Minimum number of epochs between the proposal end epoch and start epoch
pub min_proposal_voting_period: u64,
Expand Down
Loading