Murisi/masp for namadillo #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure removal of MASP Builder data.
…eters cannot be reused. Fixed MASP integration tests depending on access to secret keys.
… MASP hardware wallet integration functionality is triggered.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
==========================================
- Coverage 74.58% 74.49% -0.09%
==========================================
Files 341 341
Lines 107484 107645 +161
==========================================
+ Hits 80167 80192 +25
- Misses 27317 27453 +136 ☔ View full report in Codecov by Sentry. |
murisi
requested review from
grarco,
tzemanovic,
mateuszjasiuk and
batconjurer
tzemanovic
reviewed
Dec 2, 2024
tzemanovic
reviewed
Dec 2, 2024
batconjurer
reviewed
Dec 2, 2024
| @@ -184,13 +184,14 @@ fn payment_addresses_list( | |||
| } | |||
|
|
|||
| /// Derives a masp spending key from the mnemonic code in the wallet. | |||
| fn shielded_key_derive( | |||
| async fn shielded_key_derive( | |||
There was a problem hiding this comment.
it's taken from #3797 without shielded keys support in HW wallet - we unfortunately already have some blocking calls mixed in the client already (e.g. wallet load) but I think we should just go with it and convert the blocking stuff to async
batconjurer
reviewed
Dec 2, 2024
murisi
force-pushed
the
murisi/masp-for-namadillo
branch
from
822426b to
53940be
Compare
murisi
force-pushed
the
murisi/masp-for-namadillo
branch
from
53940be to
49a4a5d
Compare
tzemanovic
approved these changes
Dec 3, 2024
tzemanovic
added
the
backport-libs-0.46
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Essentially #3797, but with MASP hardware wallet integration disabled. Hardware wallet integration was disabled because (modified) ZIP 32 derivations are not yet supported by the device. Despite this, this PR is still useful because it separates MASP transaction building from MASP transaction signing, which is required for securely implementing MASP transactions on Namadillo.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo