Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (e3fd6ac) and #4127 together #4141

Closed
wants to merge 19 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (e3fd6ac) and #4127 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #4127.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (2)
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-integration
    • check-neutral = test-integration
    • check-skipped = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 4127
...

murisi and others added 19 commits November 27, 2024 10:38
…eters cannot be reused. Fixed MASP integration tests depending on access to secret keys.
… MASP hardware wallet integration functionality is triggered.
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 140 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (e3fd6ac) to head (fb7337c).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
crates/wallet/src/store.rs 25.00% 60 Missing ⚠️
crates/wallet/src/lib.rs 33.33% 32 Missing ⚠️
crates/wallet/src/keys.rs 32.14% 19 Missing ⚠️
crates/sdk/src/tx.rs 73.91% 6 Missing ⚠️
crates/core/src/masp.rs 78.26% 5 Missing ⚠️
crates/apps_lib/src/wallet/defaults.rs 0.00% 4 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 4 Missing ⚠️
crates/tx/src/types.rs 84.21% 3 Missing ⚠️
crates/apps_lib/src/config/genesis/transactions.rs 0.00% 2 Missing ⚠️
crates/apps_lib/src/config/genesis/utils.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4141      +/-   ##
==========================================
- Coverage   74.56%   74.50%   -0.06%     
==========================================
  Files         341      341              
  Lines      107502   107663     +161     
==========================================
+ Hits        80158    80218      +60     
- Misses      27344    27445     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot closed this Dec 5, 2024
@mergify mergify bot deleted the mergify/merge-queue/f37557ba93 branch December 5, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants