Closed
Conversation
…ndows # Conflicts: # packages/opencode/src/pty/index.ts # packages/opencode/src/tool/skill.ts
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This reverts commit 77a1ef2.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~75% of this PR is test code
From the new architecture tests to help force pit of success down the line:
For me to manually test each one by one:
Fixes
Core Path Normalization
test/lsp/document-symbol-paths.test.ts→ "windows: converts file:// URI to drive-letter path"test/tool/diagnostics-paths.test.ts→ "accepts posix diagnostics keys", "windows: accepts canonical diagnostics keys"test/tool/glob-paths.test.ts→ "windows: accepts MSYS-style absolute search paths"test/tool/grep-paths.test.ts→ "windows: accepts MSYS-style absolute search paths"test/util/path.test.ts→ "converts Git Bash / MSYS paths", "normalize() converts MSYS roots"test/tool/bash.test.ts→ "resolves relative workdir against Instance.directory", "throws on invalid workdir"test/server/pty.test.ts→ "throws for invalid cwd"test/tool/bash-paths.test.ts→ "converts MSYS paths to drive-letter posix", "preserves UNC shares"test/tool/external-directory.test.ts→ "windows: normalizes MSYS-style absolute targets"test/permission/next.test.ts→ "evaluate - matches stored backslash patterns", "evaluate - matches case-insensitively"test/util/path.test.ts→ "normalizes standard paths", "joins with forward slashes", "resolve() output contains no backslashes", "handles mixed slashes"test/util/no-native-path-imports.test.ts→ "repo source avoids native path imports"test/worktree/worktree-paths.test.ts→ "remove matches worktrees case-insensitively", "reset blocks primary workspace case-insensitively"test/tool/bash-paths.test.ts→ "converts MSYS paths to drive-letter posix"test/util/path.test.ts→ "converts Git Bash / MSYS paths"test/tool/bash.test.ts→ "asks for external_directory permission even when PATH is broken"test/server/session-list.test.ts→ "filters by directory with trailing separator"test/project/instance-paths.test.ts→ "canonicalizes short and long paths to same directory"test/permission/next.test.ts→ "fromConfig - normalizes windows-style backslashes for path permissions", "fromConfig - normalizes MSYS roots for path permissions", "evaluate - matches stored backslash patterns for path permissions", "evaluate - matches case-insensitively for path permissions"test/tool/edit-paths.test.ts→ "windows: accepts MSYS-style absolute file paths"test/tool/write-paths.test.ts→ "windows: accepts MSYS-style absolute file paths"test/tool/multiedit-paths.test.ts→ "windows: accepts MSYS-style absolute file paths"LSP & Ripgrep
test/lsp/document-symbol-paths.test.ts→ "windows: converts file:// URI to drive-letter path"test/lsp/index.test.ts→ "skips servers with invalid roots"test/tool/diagnostics-paths.test.ts→ "accepts posix diagnostics keys", "windows: accepts canonical diagnostics keys"test/tool/grep-paths.test.ts→ "windows: accepts MSYS-style absolute search paths"test/file/ripgrep.test.ts(updated with toPosix)Glob/File Operations
test/config/config.test.ts→ "windows: handles file inclusion substitution with MSYS absolute paths"test/util/filesystem.test.ts→ "globUp() returns posix absolute paths on Windows"commands/directory not recognized on Windows, onlycommand/works #9335test/config/config.test.ts→ "windows: loads commands when instance directory is MSYS path"test/tool/diagnostics-paths.test.ts→ "accepts posix diagnostics keys", "windows: accepts canonical diagnostics keys"test/tool/edit-paths.test.ts→ "windows: accepts MSYS-style absolute file paths"test/util/path.test.ts→ "windows: converts extended-length drive paths", "windows: converts extended-length UNC paths"test/tool/bash-paths.test.ts→ "never returns backslashes"Permission/Security
test/file/path-traversal.test.ts→ "windows: blocks cross-drive paths", "windows: treats UNC shares as distinct roots"test/permission/next.test.ts→ "fromConfig - normalizes windows-style backslashes for path permissions", "fromConfig - normalizes MSYS roots for path permissions", "evaluate - matches stored backslash patterns for path permissions", "evaluate - matches case-insensitively for path permissions"New Test Files Added (16)
test/lsp/document-symbol-paths.test.tstest/lsp/index.test.tstest/project/instance-paths.test.tstest/server/pty.test.tstest/session/prompt.test.tstest/tool/bash-paths.test.tstest/tool/diagnostics-paths.test.tstest/tool/edit-paths.test.tstest/tool/glob-paths.test.tstest/tool/grep-paths.test.tstest/tool/lsp-paths.test.tstest/tool/multiedit-paths.test.tstest/tool/write-paths.test.tstest/util/no-native-path-imports.test.tstest/util/path.test.tstest/worktree/worktree-paths.test.ts