fix: add timeout to BunProc.run to fix network monitor related hangs
#4701
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwinchester
changed the title
BunProc.run to fix network monitor hangs
github-actions
bot
force-pushed
the
dev
branch
from
f8ee907 to
6a9856d
Compare
ryanwinchester
changed the title
BunProc.run to fix network monitor hangsBunProc.run to fix network monitor hangs
ryanwinchester
changed the title
BunProc.run to fix network monitor hangsBunProc.run to fix network monitor related hangs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a network monitor like LuLu or Little Snitch that requires permission to make network requests, opencode hangs and never recovers requiring it to be forcefully quit or killed.
This seems to stop that from happening.
i added increasing timeouts because waiting a long time sucks, so the first one is quicker, but in case some people are on slow connections they get a better shot after that? ¯\_(ツ)_/¯
Fixes #421