fix: system theme flicker #5842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2025 14:40
When user has system theme set wait for system theme to load before loading ui. Add error fallback to getCustomThemes.
Collaborator
|
/review |
Contributor
|
lgtm |
Collaborator
|
this was such an annoying little bug so thank u for fixing! |
rekram1-node
pushed a commit
that referenced
this pull request
Dec 27, 2025
Co-authored-by: Shpetim <shpetim.alimi@ndbit.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using theme: "system" the ui flickers during initial load #4472.
Fixed by waiting for system theme to load before allowing children of theme provider to render. (same as custom theme)
Screen.Recording.2025-12-20.at.2.52.42.PM.mov
If theme set to system and fails to load we fallback to opencode theme.
Screen.Recording.2025-12-20.at.2.57.31.PM.mov
Loading with custom theme:
Screen.Recording.2025-12-20.at.2.58.56.PM.mov