fix(server): handle query params in MIME type detection for proxied assets #6592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract pathname without query params/hash before checking extensions - Add charset=utf-8 for text-based MIME types (js, mjs, css, json) - Maintain original behavior: always set Content-Type for static assets - Remove .html from mimeTypes to avoid overriding Cloudflare's correct type Fixes issue where module scripts failed to load with empty MIME type when paths contained query parameters (e.g., /file.js?v=123)
Author
|
Closing as #6587 is sufficient for the current production build setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves upon #6587 by fixing a bug where MIME type detection fails for URLs with query parameters or hash fragments.
Problem
The current implementation (from #6587) uses
path.endsWith(ext)which fails for:/assets/file.js?v=123- common for cache busting/assets/file.js#source-map- used in source mapsThis causes these files to be served without Content-Type headers, breaking module loading.
Changes
charset=utf-8to text-based MIME types (JS, CSS, JSON) for standards compliance