Skip to content

fix(server): handle query params in MIME type detection for proxied assets #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KoMinkyu wants to merge 1 commit into from
Closed

fix(server): handle query params in MIME type detection for proxied assets #6592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/opencode/src/server/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,10 +2666,10 @@ export namespace Server {
})
// Cloudflare doesn't return Content-Type for static assets, so we need to add it
const mimeTypes: Record<string, string> = {
".js": "application/javascript",
".mjs": "application/javascript",
".css": "text/css",
".json": "application/json",
".js": "application/javascript; charset=utf-8",
".mjs": "application/javascript; charset=utf-8",
".css": "text/css; charset=utf-8",
".json": "application/json; charset=utf-8",
".wasm": "application/wasm",
".svg": "image/svg+xml",
".png": "image/png",
Expand All @@ -2683,8 +2683,10 @@ export namespace Server {
".ttf": "font/ttf",
".eot": "application/vnd.ms-fontobject",
}
// Extract pathname without query parameters or hash fragments
const pathname = path.split("?")[0].split("#")[0]
for (const [ext, mime] of Object.entries(mimeTypes)) {
if (path.endsWith(ext)) {
if (pathname.endsWith(ext)) {
const headers = new Headers(response.headers)
headers.set("Content-Type", mime)
return new Response(response.body, {
Expand Down