Skip to content

fix(ui): add timeout cleanup in TextField copy handler #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vtemian wants to merge 1 commit into from
Closed

fix(ui): add timeout cleanup in TextField copy handler #7480

vtemian wants to merge 1 commit into from

Conversation

@vtemian
Copy link
Contributor

@vtemian vtemian commented Jan 9, 2026

Summary

  • Fix potential memory leak in TextField copy button
  • Use reactive effect pattern for timeout management
  • Auto-cleanup on rapid clicks and component unmount

Changes

The copy feedback timeout (2s "Copied" indicator) now uses createEffect with onCleanup instead of a bare setTimeout. This ensures:

  • Previous timeout is cleared on rapid clicks
  • Timeout is cleared on component unmount
  • No state updates on unmounted components

@vtemian
fix(ui): add timeout cleanup in TextField copy handler
70c6f04 
Use reactive effect pattern to handle copy feedback timeout.
The effect auto-cleans up on re-run (rapid clicks) and component
unmount, preventing state updates on unmounted components.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@vtemian vtemian closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vtemian