Skip to content

fix(ui): add timeout cleanup in TextField copy handler #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vtemian wants to merge 1 commit into from
Closed

fix(ui): add timeout cleanup in TextField copy handler #7480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/ui/src/components/text-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { TextField as Kobalte } from "@kobalte/core/text-field"
import { createSignal, Show, splitProps } from "solid-js"
import { createEffect, createSignal, onCleanup, Show, splitProps } from "solid-js"
import type { ComponentProps } from "solid-js"
import { IconButton } from "./icon-button"
import { Tooltip } from "./tooltip"
Expand Down Expand Up @@ -51,11 +51,16 @@ export function TextField(props: TextFieldProps) {
])
const [copied, setCopied] = createSignal(false)

createEffect(() => {
if (!copied()) return
const timeout = setTimeout(() => setCopied(false), 2000)
onCleanup(() => clearTimeout(timeout))
})

async function handleCopy() {
const value = local.value ?? local.defaultValue ?? ""
await navigator.clipboard.writeText(value)
setCopied(true)
setTimeout(() => setCopied(false), 2000)
}

function handleClick() {
Expand Down
Loading