Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0.0] xfconf - deprecate parameter disable_facts #4520

Merged
merged 5 commits into from
May 17, 2022
Merged

[6.0.0] xfconf - deprecate parameter disable_facts #4520

merged 5 commits into from
May 17, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 17, 2022 •
edited
Loading

SUMMARY

Parameter has only one accepted value since community.general 4.0.0

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

xfconf

@ansibullbot
Copy link
Collaborator

cc @jbenden
click here for bot help

@ansibullbot ansibullbot added docs docs_only module module plugins plugin (any type) small_patch Hopefully easy to review system and removed docs_only small_patch Hopefully easy to review labels Apr 17, 2022
@russoz russoz changed the title xfconf: deprecate parameter disable_facts [5.0.0] xfconf - deprecate parameter disable_facts Apr 18, 2022
@russoz russoz changed the title [5.0.0] xfconf - deprecate parameter disable_facts [6.0.0] xfconf - deprecate parameter disable_facts Apr 19, 2022
felixfontein
felixfontein reviewed Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option still needs to be actually deprecated (in line 173). Right now it is only documented as deprecated.

changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 19, 2022
@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 20, 2022
@russoz russoz force-pushed the xfconf-deprecate-disable-facts branch from 126048f to 5a67708 Compare April 24, 2022 06:25
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 24, 2022
felixfontein
felixfontein requested changes Apr 24, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to actually deprecate the option. Right now it is not.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 24, 2022
felixfontein
felixfontein approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged once stable-5 has been branched.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 25, 2022
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 3, 2022
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
docs module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein