Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] xfconf - deprecate parameter disable_facts #4520

Merged
merged 5 commits into from
May 17, 2022
Merged

[6.0.0] xfconf - deprecate parameter disable_facts #4520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ca8b2c
xfconf: deprecate parameter disable_facts
russoz Apr 17, 2022
e96c75e
added changelog fragment
russoz Apr 17, 2022
68a76b6
changed deprecation to 8.0.0
russoz Apr 19, 2022
5a67708
Update changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml
russoz Apr 19, 2022
7e8217c
added parameter deprecation
russoz Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/4520-xfconf-deprecate-disable-facts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
deprecated_features:
- xfconf - deprecated parameter ``disable_facts``, as since version 4.0.0 it only allows value ``true`` (https://github.com/ansible-collections/community.general/pull/4520).
8 changes: 6 additions & 2 deletions plugins/modules/system/xfconf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
disable_facts:
description:
- The value C(false) is no longer allowed since community.general 4.0.0.
- This option will be deprecated in a future version, and eventually be removed.
- This option is deprecated, and will be removed in community.general 8.0.0.
type: bool
default: true
version_added: 2.1.0
Expand Down Expand Up @@ -185,7 +185,11 @@ class XFConfProperty(CmdStateModuleHelper):
choices=('string', 'int', 'double', 'bool', 'uint', 'uchar', 'char', 'uint64', 'int64', 'float')),
value=dict(type='list', elements='raw'),
force_array=dict(type='bool', default=False, aliases=['array']),
disable_facts=dict(type='bool', default=True),
disable_facts=dict(
type='bool', default=True,
removed_in_version='8.0.0',
removed_from_collection='community.general'
),
),
required_if=[('state', 'present', ['value', 'value_type'])],
required_together=[('value', 'value_type')],
Expand Down