Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: refactoring #4650

Merged
merged 2 commits into from
May 8, 2022
Merged

zfs: refactoring #4650

merged 2 commits into from
May 8, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented May 8, 2022

SUMMARY

Minor refactorings.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/storage/zfs/zfs.py

@ansibullbot
Copy link
Collaborator

cc @bcoca @fishman @jasperla @johanwiren @jpdasma @mator @scathatheworm @troy2914 @xen0l
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) storage and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 8, 2022
felixfontein
felixfontein approved these changes May 8, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit b9266c3 into ansible-collections:main May 8, 2022
@felixfontein
Copy link
Collaborator

@russoz thanks for improving this!

@russoz russoz deleted the zfs-improvements branch May 9, 2022 00:54
@felixfontein felixfontein mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type) storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein