Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quoting bug in zfs #4726

Merged
merged 1 commit into from
May 28, 2022
Merged

Fix quoting bug in zfs #4726

merged 1 commit into from
May 28, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #4707.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zfs

@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. and removed backport-4 labels May 24, 2022
@felixfontein felixfontein mentioned this pull request May 24, 2022
Closed
1 task
@felixfontein
Copy link
Collaborator Author

This bug got introduced in #4650, CC @russoz

Thanks to @sw104 for analyzing the problem!

@ansibullbot
Copy link
Collaborator

cc @bcoca @fishman @jasperla @johanwiren @jpdasma @mator @scathatheworm @troy2914 @xen0l
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) storage labels May 24, 2022
russoz
russoz approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it!
LGTM

@felixfontein felixfontein merged commit 01b32fe into ansible-collections:main May 28, 2022
@patchback
Copy link

patchback bot commented May 28, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/01b32fec14316dd1785938796d04df6ac75570eb/pr-4726

Backported as #4744

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the zfs branch May 28, 2022 19:38
patchback bot pushed a commit that referenced this pull request May 28, 2022
@felixfontein @patchback
Fix quoting bug in zfs. (#4726)
05c1dcc 
(cherry picked from commit 01b32fe)
@patchback patchback bot mentioned this pull request May 28, 2022
Merged
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 28, 2022
felixfontein added a commit that referenced this pull request May 29, 2022
@patchback @felixfontein
Fix quoting bug in zfs. (#4726) (#4744)
6252f3b 
(cherry picked from commit 01b32fe)

Co-authored-by: Felix Fontein <felix@fontein.de>
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@lumiere-bot lumiere-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ergho-bot ergho-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@angelnu-bot angelnu-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ghost ghost mentioned this pull request Nov 7, 2022
Merged
1 task
@feisar-bot feisar-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@iudicael-bot iudicael-bot bot mentioned this pull request Nov 7, 2022
Closed
1 task
@negative-7-bot negative-7-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New ZFS create fails when you specify mount point
3 participants
@felixfontein @ansibullbot @russoz