Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace value with newer requests #310

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

@briantist briantist added the bug Something isn't working label Oct 18, 2022
@briantist briantist self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #310 (e27c104) into main (0bac5df) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e27c104 differs from pull request most recent head ee87264. Consider uploading reports for the commit ee87264 to get more accurate results

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          73       73           
  Lines        3679     3679           
  Branches      313      241   -72     
=======================================
  Hits         3630     3630           
  Misses         40       40           
  Partials        9        9           
Flag Coverage Δ
env_docker-default 98.66% <100.00%> (ø)
integration 81.02% <100.00%> (ø)
sanity 38.88% <100.00%> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_azure 53.84% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.07% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.30% <100.00%> (+0.05%) ⬆️
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 38.88% <100.00%> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 55.87% <100.00%> (ø)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.66% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.57% <100.00%> (ø)
target_module_utils 97.08% <100.00%> (+0.06%) ⬆️
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_login 83.72% <ø> (ø)
target_module_vault_pki_generate_certificate 78.72% <ø> (ø)
target_module_vault_read 85.71% <ø> (ø)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.46% <100.00%> (ø)
target_modules 78.61% <100.00%> (ø)
units 96.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_hashi_vault_common.py 100.00% <100.00%> (ø)
...ins/plugin_utils/authentication/test_auth_token.py 100.00% <100.00%> (ø)
...it/plugins/plugin_utils/test_hashi_vault_helper.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception using requests-2.28.1
1 participant