Fix namespace value with newer requests

changelogs/fragments/309-stringify-namespace.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - connection options - the ``namespace`` connection option will be forced into a string to ensure cmpatibility with recent ``requests`` versions (https://github.com/ansible-collections/community.hashi_vault/issues/309).

plugins/module_utils/_hashi_vault_common.py

@@ -53,13 +53,14 @@ class HashiVaultValueError(ValueError):
 
 class HashiVaultHelper():
 
-    STRINGIFY_CANDIDATES = set(
+    STRINGIFY_CANDIDATES = set([
         'token',    # Token will end up in a header, requests requires headers to be str or bytes,
                     # and newer versions of requests stopped converting automatically. Because our
                     # token could have been passed in from a previous lookup call, it could be one
                     # of the AnsibleUnsafe types instead, causing a failure. Tokens should always
                     # be strings, so we will convert them.
-    )
+        'namespace',    # namespace is also set in a header
+    ])
 
     def __init__(self):
         # TODO move hvac checking here?

tests/unit/plugins/plugin_utils/authentication/test_auth_token.py

@@ -29,7 +29,7 @@ def option_dict():
 
 
 @pytest.fixture(params=[AnsibleUnsafeBytes(b'ub_opaque'), AnsibleUnsafeText(u'ut_opaque'), b'b_opaque', u't_opaque'])
-def token(request):
+def stringy(request):
     return request.param
 
 
@@ -39,9 +39,8 @@ def auth_token(adapter, warner, deprecator):
 
 
 class TestAuthToken(object):
-
-    def test_auth_token_unsafes(self, auth_token, client, adapter, token):
-        adapter.set_option('token', token)
+    def test_auth_token_unsafes(self, auth_token, client, adapter, stringy):
+        adapter.set_option('token', stringy)
         adapter.set_option('token_validate', False)
 
         wrapper = mock.Mock(wraps=auth_token._stringify)

tests/unit/plugins/plugin_utils/test_hashi_vault_helper.py

@@ -8,7 +8,7 @@
 
 import pytest
 
-from ansible.utils.unsafe_proxy import AnsibleUnsafe, AnsibleUnsafeBytes, AnsibleUnsafeText
+from ansible.utils.unsafe_proxy import AnsibleUnsafeBytes, AnsibleUnsafeText
 
 from ansible_collections.community.hashi_vault.tests.unit.compat import mock
 from ansible_collections.community.hashi_vault.plugins.module_utils._hashi_vault_common import HashiVaultHelper
@@ -21,9 +21,10 @@ def hashi_vault_helper():
 
 @pytest.fixture
 def expected_stringify_candidates():
-    return set(
+    return set([
         'token',
-    )
+        'namespace',
+    ])
 
 
 class TestHashiVaultHelper(object):