Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openshift_route module for route creation #40

Merged
merged 17 commits into from
Oct 5, 2020

Conversation

fabianvf
Copy link
Member

@fabianvf fabianvf commented Sep 29, 2020

SUMMARY

Adds a new openshift_route module, which handles creating routes from services. Parameters and functionality are an amalgamation of oc expose and oc create route.

Fixes #31

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

openshift_route

ADDITIONAL INFORMATION

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@fabianvf fabianvf changed the title Add openshift_expose module for route creation Add openshift_route module for route creation Sep 30, 2020
Copy link
Member

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
Copy link
Contributor

@tima tima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2020
@tima
Copy link
Contributor

tima commented Oct 3, 2020

/retest

namespace: default
name: hello-kubernetes-https
tls:
insecure_policy: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing the integration tests to fail with a "msg" of "value of insecure_policy must be one of: allow, redirect, got: None found in tls".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd that it passed locally, must have been a stale version of the collection or something. Added an explicit disable option for disallowing insecure traffic, should be good to go now

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
- Sets the InsecureEdgeTerminationPolicy for the Route.
- Not supported when I(termination) is set to reencrypt.
- When I(termination) is set to passthrough, only redirect is supported.
- If not provided, insecure traffic will be disallowed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insecure_policy should have a default of "disallow" or this line should be removed.

@tima
Copy link
Contributor

tima commented Oct 5, 2020

lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, maxamillion, tima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabianvf,maxamillion,tima]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e7c3351 into openshift:main Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Module: openshift_route
5 participants