-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openshift_route module for route creation #40
Add openshift_route module for route creation #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
namespace: default | ||
name: hello-kubernetes-https | ||
tls: | ||
insecure_policy: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing the integration tests to fail with a "msg" of "value of insecure_policy must be one of: allow, redirect, got: None found in tls".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
odd that it passed locally, must have been a stale version of the collection or something. Added an explicit disable
option for disallowing insecure traffic, should be good to go now
cebf0a6
to
cbe8572
Compare
- Sets the InsecureEdgeTerminationPolicy for the Route. | ||
- Not supported when I(termination) is set to reencrypt. | ||
- When I(termination) is set to passthrough, only redirect is supported. | ||
- If not provided, insecure traffic will be disallowed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insecure_policy
should have a default of "disallow" or this line should be removed.
lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, maxamillion, tima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SUMMARY
Adds a new openshift_route module, which handles creating routes from services. Parameters and functionality are an amalgamation of
oc expose
andoc create route
.Fixes #31
ISSUE TYPE
COMPONENT NAME
openshift_route
ADDITIONAL INFORMATION