Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zos_data_set member description created #791

Merged
merged 15 commits into from
Jun 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ac
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,9 @@ ac_test(){
done
fi

# Clean up the collections folder after running the tests, temporary work around.
rm -rf collections/ansible_collections

#cd ${CURR_DIR}
}

Expand Down
17 changes: 17 additions & 0 deletions changelogs/fragments/791-zos_data_set-update-vsam.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
trivial:
- zos_data_set - when a member is created by the module, the format is type
data which is not suitable for executables. This change describes the
format used when creating member.
(https://github.com/ansible-collections/ibm_zos_core/pull/791)
- ac - Reported an issue when functional tests ran leaving behind files. Fix
now removes the unwanted files.
(https://github.com/ansible-collections/ibm_zos_core/pull/791)
bugfixes:
- zos_data_set - Reported a failure caused when `present=absent` for a VSAM
data set leaving behind cluster components. Fix introduces a new logical
flow that will evaluate the volumes, compare it to the provided value and
if necessary catalog and delete.
(https://github.com/ansible-collections/ibm_zos_core/pull/791).
- module_utils - data_set.py - Reported a failure caused when cataloging a
VSAM data set. Fix now corrects how VSAM data sets are cataloged.
(https://github.com/ansible-collections/ibm_zos_core/pull/791).
18 changes: 15 additions & 3 deletions docs/source/modules/zos_data_set.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ state
If *state=absent* and *volumes* is provided, and the data set is not found in the catalog, the module attempts to perform catalog using supplied *name* and *volumes*. If the attempt to catalog the data set catalog fails, then no action is taken. Module completes successfully with *changed=False*.


If *state=absent* and *volumes* is provided, and the data set is found in the catalog, the module compares the catalog volume attributes to the provided *volumes*. If they volume attributes are different, the cataloged data set will be uncataloged temporarily while the requested data set be deleted is cataloged. The module will catalog the original data set on completion, if the attempts to catalog fail, no action is taken. Module completes successfully with *changed=False*.


If *state=present* and the data set does not exist on the managed node, create and catalog the data set, module completes successfully with *changed=True*.


Expand All @@ -65,6 +68,9 @@ state
If *state=present* and *replace=False* and the data set is present on the managed node, no action taken, module completes successfully with *changed=False*.


If *state=present* and *type=MEMBER* and the member does not exist in the data set, create a member formatted to store data, module completes successfully with *changed=True*. Note, a PDSE does not allow a mixture of formats such that there is executables (program objects) and data. The member created is formatted to store data, not an executable.


If *state=cataloged* and *volumes* is provided and the data set is already cataloged, no action taken, module completes successfully with *changed=False*.


Expand All @@ -74,7 +80,7 @@ state
If *state=cataloged* and *volumes* is provided and the data set is not cataloged, module attempts to perform catalog using supplied *name* and *volumes*. If the attempt to catalog the data set catalog fails, returns failure with *changed=False*.


If *state=uncataloged* and the data set is not found, no action taken , module completes successfully with *changed=False*.
If *state=uncataloged* and the data set is not found, no action taken, module completes successfully with *changed=False*.


If *state=uncataloged* and the data set is found, the data set is uncataloged, module completes successfully with *changed=True*.
Expand Down Expand Up @@ -321,6 +327,9 @@ batch
If *state=absent* and *volumes* is provided, and the data set is not found in the catalog, the module attempts to perform catalog using supplied *name* and *volumes*. If the attempt to catalog the data set catalog fails, then no action is taken. Module completes successfully with *changed=False*.


If *state=absent* and *volumes* is provided, and the data set is found in the catalog, the module compares the catalog volume attributes to the provided *volumes*. If they volume attributes are different, the cataloged data set will be uncataloged temporarily while the requested data set be deleted is cataloged. The module will catalog the original data set on completion, if the attempts to catalog fail, no action is taken. Module completes successfully with *changed=False*.


If *state=present* and the data set does not exist on the managed node, create and catalog the data set, module completes successfully with *changed=True*.


Expand All @@ -330,6 +339,9 @@ batch
If *state=present* and *replace=False* and the data set is present on the managed node, no action taken, module completes successfully with *changed=False*.


If *state=present* and *type=MEMBER* and the member does not exist in the data set, create a member formatted to store data, module completes successfully with *changed=True*. Note, a PDSE does not allow a mixture of formats such that there is executables (program objects) and data. The member created is formatted to store data, not an executable.


If *state=cataloged* and *volumes* is provided and the data set is already cataloged, no action taken, module completes successfully with *changed=False*.


Expand All @@ -339,7 +351,7 @@ batch
If *state=cataloged* and *volumes* is provided and the data set is not cataloged, module attempts to perform catalog using supplied *name* and *volumes*. If the attempt to catalog the data set catalog fails, returns failure with *changed=False*.


If *state=uncataloged* and the data set is not found, no action taken , module completes successfully with *changed=False*.
If *state=uncataloged* and the data set is not found, no action taken, module completes successfully with *changed=False*.


If *state=uncataloged* and the data set is found, the data set is uncataloged, module completes successfully with *changed=True*.
Expand All @@ -352,7 +364,7 @@ batch


type
The data set type to be used when creating a data set. (e.g ``pdse``)
The data set type to be used when creating a data set. (e.g ``PDSE``)

``MEMBER`` expects to be used with an existing partitioned data set.

Expand Down
51 changes: 49 additions & 2 deletions docs/source/modules/zos_job_query.rst
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,31 @@ jobs

[
{
"asid": 0,
"creation_datetime": "20230503T121300",
"job_class": "K",
"job_id": "JOB01427",
"job_name": "LINKJOB",
"owner": "ADMIN",
"ret_code": "null"
"priority": 1,
"queue_position": 3,
"ret_code": "null",
"svc_class": "?"
},
{
"asid": 4,
"creation_datetime": "20230503T121400",
"job_class": "A",
"job_id": "JOB16577",
"job_name": "LINKCBL",
"owner": "ADMIN",
"priority": 0,
"queue_position": 0,
"ret_code": {
"code": "null",
"msg": "CANCELED"
}
},
"svc_class": "E"
}
]

Expand Down Expand Up @@ -232,6 +244,41 @@ jobs



job_class
Letter indicating job class for this job.

| **type**: str
| **sample**: A

svc_class
Character indicating service class for this job.

| **type**: str
| **sample**: C

priority
A numeric indicator of the job priority assigned through JES.

| **type**: int
| **sample**: 4

asid
An identifier created by JES.

| **type**: int

creation_datetime
Date and time, local to the target system, when the job was created.

| **type**: str
| **sample**: 20230504T141500

queue_position
Integer of the position within the job queue where this jobs resided.

| **type**: int
| **sample**: 3


message
Message returned on failure.
Expand Down
43 changes: 42 additions & 1 deletion docs/source/modules/zos_job_submit.rst
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,10 @@ jobs

[
{
"asid": 0,
"class": "K",
"content_type": "JOB",
"creation_datetime": "20230503T121300",
"ddnames": [
{
"byte_count": "677",
Expand Down Expand Up @@ -419,9 +421,12 @@ jobs
"stepname": "DLORD6"
}
],
"job_class": "K",
"job_id": "JOB00361",
"job_name": "DBDGEN00",
"owner": "OMVSADM",
"priority": 1,
"queue_position": 3,
"ret_code": {
"code": 0,
"msg": "CC 0000",
Expand All @@ -434,7 +439,8 @@ jobs
}
]
},
"subsystem": "STL1"
"subsystem": "STL1",
"svc_class": "?"
}
]

Expand Down Expand Up @@ -588,6 +594,41 @@ jobs



job_class
Letter indicating job class for this job.

| **type**: str
| **sample**: A

svc_class
Character indicating service class for this job.

| **type**: str
| **sample**: C

priority
A numeric indicator of the job priority assigned through JES.

| **type**: int
| **sample**: 4

asid
An identifier created by JES.

| **type**: int

creation_datetime
Date and time, local to the target system, when the job was created.

| **type**: str
| **sample**: 20230504T141500

queue_position
Integer of the position within the job queue where this jobs resided.

| **type**: int
| **sample**: 3


message
This option is being deprecated
Expand Down
2 changes: 1 addition & 1 deletion meta/runtime.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
requires_ansible: '>=2.9,<2.15'
requires_ansible: '>=2.9,<2.16'
Loading