-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zos_data_set member description created #791
Conversation
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
…s user to correctly delete DS not in cat Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested for changelog and unused import.
Questions about 2 rst files apparently not related to this PR and use of run_command for mvs_cmd
Signed-off-by: ddimatos <dimatos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ok for me now, I get that having this in our dev branch will benefit us immediately. mvs_cmd can be standarized later and unused imports actually are shown get using the latest ansible 2.15 sanity scan so we will clean it 🙂 .
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Imports removed from data_sets.py, thought you were referring to the pprint in the test cases, which is referenced by an unused method. Sanity ran clean on 2.15 and 2.16. |
…time 2.16 Signed-off-by: ddimatos <dimatos@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Also includes issue #803 which was left out of the description. |
SUMMARY
Given this change will drive over 700 tests it made sense to collapse all the related zos_data_set into one PR to avoid multiple regression pipelines.
Documentation: When a MEMBER is created, the format type of the member was not described, it should be clearly defined so that a user does not try to insert an executable into the data formatted member. Issue [Documentation] [zos_data_set] Update member doc to explain what type of member is created #631
Bug: A random issue would occur on the pipeline leaving behind VSAM cluster components be it INDEX or DATA, originally this was thought to be a test case issue and a simple test fix but after reviewing I found it much more complex and took a better part of the week to address. To fix this I had to undo most of what was done in PR 325 for bugfix [Bug] [zos_data_set] should not ignore supplied volumes #140. Although this was a good attempt, the issue was that only one of the cluster components were being deleted here with a
DELETE USER.PRIVATE.TESTDS.DATA FILE(DD1) VVR
while adding the other for INDEX would have been a suitable fix, the issue such a clean up leaves space unclaimed on the volume and not the correct way to back out a data set from z/OS. Thus introduced a flow of tracking state and uncatalog, catalog, delete to achieve this, see image below for most the flow, the flow has since changed with some added exception actions but mostly the flow is correct for reference. Issue [Enabler] [CI/CD] Failing to clean up environtment causes a failure. #635The catalog commands were failing because of formatting, I might have been happening for a long time because of all this other related issues it might not have been apparent, thus now the commands are formatted correctly and tested. Issue [Bug] zos_data_set data_set.py utils cataloging failures #802
Small .ac command issue where some files are left behind were cleaned up as part of this PR because I was using
./ac --ac-test
and it was inhibiting my ability to work to not fix it.Data set deletion flow.
![image](https://private-user-images.githubusercontent.com/25803172/244824804-31ba9295-a3f9-45d6-92cf-35ab795263a2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mjk4NDksIm5iZiI6MTczOTUyOTU0OSwicGF0aCI6Ii8yNTgwMzE3Mi8yNDQ4MjQ4MDQtMzFiYTkyOTUtYTNmOS00NWQ2LTkyY2YtMzVhYjc5NTI2M2EyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDEwMzkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5NGM2ZTQ1MTI2OTc1NTU4ZjZjNGI3NWJlNTAzYmQ3YTljNzk4ZjY1ZWYyM2I0MDU5MjQ0YjkwZjlhY2IzYmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-L59mSA8OWSvO5vtrJyLqzOwmujt-EBjX1JycpqS0bM)
ISSUE TYPE