-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated servicenow.servicenow from Ansible 9 #254
Remove deprecated servicenow.servicenow from Ansible 9 #254
Conversation
9198476
to
bb33a2d
Compare
8/ansible-8.build
Outdated
@@ -99,7 +99,6 @@ purestorage.flasharray: >=1.18.0,<2.0.0 | |||
purestorage.flashblade: >=1.11.0,<2.0.0 | |||
purestorage.fusion: >=1.4.0,<2.0.0 | |||
sensu.sensu_go: >=1.13.0,<2.0.0 | |||
servicenow.servicenow: >=1.0.0,<2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collection MUST NOT be removed from Ansible 8. This is a breaking change and thus not acceptable since Ansible sticks to semantic versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the only place we have to change in this case... let me have a look and do another commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfontein I think it should be OK now.
a844959
to
dbaaa9e
Compare
@felixfontein BTW if you think this change is OK now and there's no need to discuss it in the next meeting, feel free to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes, after that we can merge it.
Co-authored-by: Felix Fontein <felix@fontein.de>
Thanks a lot for fixing this! I really wonder how that collection managed to sneak back in... |
See ansible-community/community-topics#246 for more information.