Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated servicenow.servicenow from Ansible 9 #254

Merged
merged 4 commits into from
Jun 24, 2023
Merged

Remove deprecated servicenow.servicenow from Ansible 9 #254

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb33a2d
Remove deprecated servicenow.servicenow from 8.2
mariolenz Jun 23, 2023
062a73b
Remove deprecated servicenow.servicenow from 9
mariolenz Jun 23, 2023
dbaaa9e
Keep service.now in 8.x
mariolenz Jun 23, 2023
8dd5053
Apply suggestions from code review
mariolenz Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion 8/ansible-8.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ purestorage.flasharray: >=1.18.0,<2.0.0
purestorage.flashblade: >=1.11.0,<2.0.0
purestorage.fusion: >=1.4.0,<2.0.0
sensu.sensu_go: >=1.13.0,<2.0.0
servicenow.servicenow: >=1.0.0,<2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collection MUST NOT be removed from Ansible 8. This is a breaking change and thus not acceptable since Ansible sticks to semantic versioning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the only place we have to change in this case... let me have a look and do another commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein I think it should be OK now.

splunk.es: >=2.1.0,<3.0.0
t_systems_mms.icinga_director: >=1.32.0,<2.0.0
theforeman.foreman: >=3.10.0,<4.0.0
Expand Down
1 change: 0 additions & 1 deletion 8/ansible.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ purestorage.flasharray
purestorage.flashblade
purestorage.fusion
sensu.sensu_go
servicenow.servicenow
splunk.es
theforeman.foreman
t_systems_mms.icinga_director
Expand Down
5 changes: 5 additions & 0 deletions 8/changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,8 @@ releases:

`Porting Guide <https://docs.ansible.com/ansible/devel/porting_guides.html>`_'
release_date: '2023-06-22'
8.2.0:
changes:
removed_features:
- The deprecated servicenow.servicenow collection has been removed from Ansible 7, but accidentally re-added to Ansible 8. It has been removed again from Ansible 8.2.0
(https://github.com/ansible-community/community-topics/issues/246).
3 changes: 0 additions & 3 deletions 8/galaxy-requirements.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,6 @@ collections:
- name: sensu.sensu_go
source: https://galaxy.ansible.com
version: 1.13.2
- name: servicenow.servicenow
source: https://galaxy.ansible.com
version: 1.0.6
- name: splunk.es
source: https://galaxy.ansible.com
version: 2.1.0
Expand Down
1 change: 0 additions & 1 deletion 9/ansible.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ purestorage.flasharray
purestorage.flashblade
purestorage.fusion
sensu.sensu_go
servicenow.servicenow
splunk.es
theforeman.foreman
t_systems_mms.icinga_director
Expand Down