vmware: Add pylint disable to skip unused imports #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GomathiselviS I would very much prefer to not ignore those sanity tests. I guess there are good reasons for them... I've fixed the sanity errors in ansible-collections/vmware.vmware_rest#432 by removing the unused imports with autoflake. This was quite simple and has the advantage of not having to ignore any sanity tests. Maybe we should discuss this in #67. |
|
Closing this PR as #70 fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some of the vmware module files throw sanity errors because of unused imports. This PR disables pylint unused import checks on the lines in the template file.
Errors seen here - https://github.com/ansible-collections/vmware.vmware_rest/actions/runs/4852914889/jobs/8648491794
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION