Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoflake to remove unused imports in cloud modules #70

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

GomathiselviS
Copy link
Collaborator

SUMMARY

This PR adds a task to the module_openapi_cloud role to remove unused imports from the generated module.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Co-authored-by: Mario Lenz <m@riolenz.de>
Copy link
Contributor

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've tested in ansible-collections/vmware.vmware_rest#438 which still fails, but for other reasons I've mentioned elsewhere. The unused imports seem to have gone :-)

Thanks @GomathiselviS!

@GomathiselviS GomathiselviS merged commit 1a8071e into ansible-community:main Nov 8, 2023
4 checks passed
@mariolenz
Copy link
Contributor

Thanks @GomathiselviS and @alinabuzachis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants