build-release: record the sha256sum of the release tarball #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsimard
force-pushed
the
build-release-checksum
branch
from
51440dd to
033c94f
Compare
|
@Ompragash ^ I added a register so it could be used a starting point for the testing you have been experimenting with |
This way we can use it in tests later. In the meantime it can be picked up by ara.
dmsimard
force-pushed
the
build-release-checksum
branch
from
033c94f to
7140912
Compare
|
Been running with this cherry-picked for a while, should be good to merge it and we can leverage it to do more testing later. |
felixfontein
reviewed
Dec 3, 2021
| - name: Record the sha256sum for the built tarball | ||
| command: sha256sum {{ _release_archive }} | ||
| changed_when: false | ||
| register: _tarball_checksum |
There was a problem hiding this comment.
Shouldn't this be used somewhere?
There was a problem hiding this comment.
ompragash had a WIP to test the sha256 against what's published to pypi -- it'll be meant for that.
We can remove it until then if you feel strongly about it.
There was a problem hiding this comment.
No, just wanted to make sure that this wasn't an oversight :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can use it in tests later.
In the meantime it can be picked up by ara.