Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-release: record the sha256sum of the release tarball #338

Merged
merged 1 commit into from
Dec 3, 2021
Merged

build-release: record the sha256sum of the release tarball #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions roles/build-release/tasks/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@
chdir: "{{ playbook_dir | dirname }}"
creates: "{{ _release_archive }}"

# We can use this to test that the release on PyPi matches later (for example)
- name: Record the sha256sum for the built tarball
command: sha256sum {{ _release_archive }}
changed_when: false
register: _tarball_checksum
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be used somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ompragash had a WIP to test the sha256 against what's published to pypi -- it'll be meant for that.
We can remove it until then if you feel strongly about it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just wanted to make sure that this wasn't an oversight :)


- name: Compute a galaxy-requirements.yml file for the release
command: >-
poetry run {{ role_path }}/files/deps-to-galaxy.py --depsfile {{ antsibull_data_dir }}/{{ _deps_file }}
Expand Down