Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1052/6d145abb backport][stable-4.4] Localization: Add first wave of translations for fr, ja and zh #1054

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 8, 2021

This is a backport of PR #1052 as merged into master (6d145ab).

Signed-off-by: Christian M. Adams chadams@redhat.com

Thanks to all of the hard work from @himdel and @jerabekjiri, we now have a translated Automation Hub UI!

Related API Localization PR - ansible/galaxy_ng#1015

Links

To check this out for yourself, stand up the galaxy_ng & ansible-hub-ui dev environment, navigate to it in the browser, and select a different language in your browser settings. Then refresh the page.

This is a beautiful sight:

image

image

This is only the initial pass, so there will be a couple missed strings here and there. These will get fixed up during the next couple string push/pull cycles.

* Localization: Add first wave of translations for fr, ja and zh

Signed-off-by: Christian M. Adams <chadams@redhat.com>

* Localization: Fix accidentally translated dynamic variables
  * I also added in the compiled .js files
Signed-off-by: Christian M. Adams <chadams@redhat.com>
(cherry picked from commit 6d145ab)
@himdel himdel merged commit 50c036d into stable-4.4 Oct 8, 2021
@himdel himdel deleted the patchback/backports/stable-4.4/6d145abbc4ed7917b9979ec9b29bacf4a726799c/pr-1052 branch October 8, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants