[l10n] Auto-mark strings for translation #677

himdel · 2021-07-21T21:09:49Z

This PR:

makes it possible to start marking strings for translation
- this does not deal with plurals (n_) or non-translating (N_) yet, just the basic version
auto-marks as many strings for translation as possible to do automatically (and fixes any errors generated during)

To achieve the first, this adds a simple _ JS string template that either behaves as regular template string, or, when localStorage.test_l10n = true is set (+reload), marks every translatable string in french quotes...

_`Hello ${ 'world' }` #=> 'Hello world'
localStorage.test_l10n = true
_`Hello ${ 'world' }` #=> '>>Hello <<world'

The latter was just a series of perl invocations to convert anything that looks like a human string,
only strings starting with a capital letter could safely be converted in some cases,
multiline strings and strings with params are not quite possible to do with regex without some major preprocessing.

    perl -i -npe 's/(?<!_)`[A-Z][^`]*`/_$&/' src/**/*.*
    perl -i -npe s/=\''([A-Z][-a-zA-Z0-9_,. ]*)'\'/'={_`$1`}'/g src/**/*.*
    perl -i -npe s/\''([A-Z][-a-zA-Z0-9_,. ]+)'\''(?!:)/_`$1`'/g src/**/*.*
    perl -i -npe s/\''([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> ]+)'\''(?!:)/_`$1`'/g src/**/*.*
    perl -i -npe s/=\''([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> ]+)'\''/={_`$1`}'/g src/**/*.*
    perl -i -npe 's/"([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> '\'']+)"(?!:)/_`$1`/g' src/**/*.*
    perl -i -npe 's/="([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> '\'']+)"/={_`$1`}/g' src/**/*.*
    perl -i -npe 's/>([A-Z][-a-zA-Z0-9_,.:?!@$%\[\] '\'']+)</>{_`$1`}</g' src/**/*.*
    perl -i -npe 's/^(\s{4,})([A-Z][-a-zA-Z0-9_,.:?!@$%\[\] '\'']+)(\s*)$/$1\{_`$2`}$3/g unless /,\s*$/' src/**/*.*

(Adding lingui itself in a separate PR, there are still problems with macros and typescript.) (AAH-803)
(Guidelines re pluralization, params coming also separately (AAH-802)

Review: please tell me about any string that's marked incorrectly or shouldn't be marked at all
(If you see a string that should be marked and isn't, just fix it outside of this PR, this should add the bulk of the changes, so we can then finish the rest manually.)

src/api/active-user.ts

src/api/base.ts

src/components/collection-detail/collection-info.tsx

src/components/patternfly-wrappers/toolbar.tsx

src/components/patternfly-wrappers/write-only-field.tsx

src/containers/namespace-detail/namespace-detail.tsx

ZitaNemeckova · 2021-07-22T09:53:24Z

src/containers/token/token-insights.tsx

            <p>
-              Use the <Link to={Paths.repositories}>Repository Management</Link>{' '}
+              Use the{' '}


This will need more love as a whole :)

ZitaNemeckova · 2021-07-22T09:53:56Z

src/containers/token/token-standalone.tsx

        <Main>
          <section className='body pf-c-content'>
-            <h2>API token</h2>
+            <h2>{_`API token`}</h2>


This will need moore love as a whole :)

ZitaNemeckova · 2021-07-22T10:00:15Z

Notes:
`String ${value}` or `String` seems to be skipped.
+ was breaking it.
<br> and <p> were breaking it. (having a space between > and string?)

himdel · 2021-07-23T13:29:25Z

@ZitaNemeckova I've added a commit dealing with `Strings`, fixed some of it in the last commit, and added a small commit the changes any _ => null into () => null, to prevent confusion with gettext.

Might be ready :)

himdel · 2021-07-26T20:26:37Z

Rebased, ready again :)

src/components/my-imports/import-list.tsx

src/components/patternfly-wrappers/compound-filter.tsx

src/containers/execution-environment-detail/tag-manifest-modal.tsx

ZitaNemeckova

Except 3 Enters LGTM 👍

…r<<' randomly in paths.ts because that's the only place which needs it at runtime (namespaceBreadcrumb) (and something is putting lodash in window._) use localStorage.test_l10n to enable marked strings

not *really* needed, but makes it easier to spot l10n if we don't use the underscore for other things

perl -i -npe 's/(?<!_)`[A-Z][^`]*`/_$&/' src/**/*.*

perl -i -npe s/=\''([A-Z][-a-zA-Z0-9_,. ]*)'\'/'={_`$1`}'/g src/**/*.*

perl -i -npe s/\''([A-Z][-a-zA-Z0-9_,. ]+)'\''(?!:)/_`$1`'/g src/**/*.*

perl -i -npe s/=\''([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> ]+)'\''/={_`$1`}'/g src/**/*.* perl -i -npe s/\''([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> ]+)'\''(?!:)/_`$1`'/g src/**/*.*

perl -i -npe 's/="([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> '\'']+)"/={_`$1`}/g' src/**/*.* perl -i -npe 's/"([A-Z][-a-zA-Z0-9_,.:?!@$%\[\]<> '\'']+)"(?!:)/_`$1`/g' src/**/*.*

perl -i -npe 's/>([A-Z][-a-zA-Z0-9_,.:?!@$%\[\] '\'']+)</>{_`$1`}</g' src/**/*.*

perl -i -npe 's/^(\s{4,})([A-Z][-a-zA-Z0-9_,.:?!@$%\[\] '\'']+)(\s*)$/$1\{_`$2`}$3/g unless /,\s*$/' src/**/*.* (with a manual fixup for 1 syntax error)