Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval Modal test #3504

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Approval Modal test #3504

merged 4 commits into from
Apr 13, 2023

Conversation

MilanPospisil
Copy link
Contributor

@MilanPospisil MilanPospisil commented Apr 4, 2023 •
edited
Loading

Requires: ansible/galaxykit#87

Issue: https://issues.redhat.com/browse/AAH-2248

Tests for approval process. Two files - one for testing the repo table in modal - paging, filtering, ordering and selection. Other for approval and rejection tests. Those are both added in new folder, so the tests can run more in parallel (approval tests were very slow even before).

@github-actions github-actions bot added the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 4, 2023
@MilanPospisil MilanPospisil changed the title Approve, Reject and Reapprove Approval Modal test Apr 4, 2023
@MilanPospisil MilanPospisil marked this pull request as draft April 4, 2023 09:16
@himdel himdel added backport-4.7 This PR should be backported to stable-4.7 (2.4) and removed backport-4.6 This PR should be backported to stable-4.6 (2.3) labels Apr 4, 2023
@MilanPospisil MilanPospisil marked this pull request as ready for review April 5, 2023 08:00
@MilanPospisil
Changes file
748fd15 
Issue: AAH-2248
@himdel himdel added the tests tests PR label Apr 13, 2023
@himdel himdel merged commit bea7ea1 into ansible:master Apr 13, 2023
@patchback
Copy link

patchback bot commented Apr 13, 2023 •
edited
Loading

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/bea7ea1860baad3badb39ffd624121b640270bbf/pr-3504

Backported as #3584

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 13, 2023
@MilanPospisil @patchback
Approval Modal test (#3504)
82360d0 
* Approve, Reject and Reapprove

* Finish approval process test, move it to separate folder
No-Issue

* Changes file
Issue: AAH-2248

* Better data-cy selector

(cherry picked from commit bea7ea1)
@patchback patchback bot mentioned this pull request Apr 13, 2023
Merged
himdel pushed a commit that referenced this pull request May 30, 2023
@patchback @MilanPospisil
Approval Modal test (#3504) (#3584)
c91f9c3 
* Approve, Reject and Reapprove

* Finish approval process test, move it to separate folder
No-Issue

* Changes file
Issue: AAH-2248

* Better data-cy selector

(cherry picked from commit bea7ea1)

Co-authored-by: MilanPospisil <arkanus@seznam.cz>
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel left review comments

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) tests tests PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilanPospisil @himdel