Galaxykit Remotes, Distributions and Repositories - create and delete #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilanPospisil
force-pushed
the
repositories
branch
from
de5b19f
to
508c91f
Compare
MilanPospisil
changed the title
MilanPospisil
force-pushed
the
repositories
branch
from
ad61948
to
c5ffc99
Compare
himdel
reviewed
Apr 5, 2023
himdel
reviewed
Apr 5, 2023
himdel
reviewed
Apr 5, 2023
himdel
reviewed
Apr 10, 2023
galaxykit/utils.py
Outdated
|
|
||
|
|
||
| def parse_pulp_id(pulp_href): | ||
| return pulp_href.split("/")[-2] |
There was a problem hiding this comment.
the index can vary depending on where the href comes from .. if you're putting this in utils, it should be looking for the uuid
.. it's already implemented as tasks.pulp_href_to_id, maybe move that one here?
.. also implemented as roles.pulp_href_to_id
(and should, but isn't used in containers.add_owner_to_ee (ns_id))
|
The rest looks good 👍 :) |
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Apr 12, 2023
No-Issue
|
Tested in ansible/ansible-hub-ui#3574 (https://github.com/ansible/ansible-hub-ui/actions/runs/4682109624/jobs/8295536826?pr=3574) ... fixing |
himdel
approved these changes
Apr 13, 2023
chr-stian
pushed a commit
that referenced
this pull request
Apr 13, 2023
…#87) * Remotes and Repositories - create and delete * Creates also distribution * Distributions * Black and add distribution.py * parsing href into id * Renaming the help texts. * pulp_href_to_id: fix missing re import, use for one more slash split --------- Co-authored-by: Martin Hradil <mhradil@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAH-2243