Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution environment form fixups #4457

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Execution environment form fixups #4457

merged 4 commits into from
Oct 31, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 30, 2023 •
edited
Loading

Noticed when reviewing ansible/ansible-ui#1054

When editing an EE:

  • tags to include/exclude allows adding an empty tag
    • => remove falsy tags when adding
  • "and a up to one (slash)" -> "and zero or one (slash)"
  • clicking on the LabelGroup "N more" and "show less" buttons submits the form (Execution Environment add or edit ansible-ui#1054 (comment))
    • => wrap LabelGroup to fix that, and inline chipGroupProps
    • (we should fix this in pf5, but this fixes it for pf4)

@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 30, 2023
@nixocio nixocio mentioned this pull request Oct 31, 2023
Merged
nixocio
nixocio approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himdel himdel merged commit 37b9afe into ansible:master Oct 31, 2023
17 of 18 checks passed
@himdel himdel deleted the ee-fixups branch October 31, 2023 18:50
@patchback Patchback

This comment was marked as outdated.

Sign in to view
@patchback Patchback

This comment was marked as outdated.

Sign in to view
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Oct 31, 2023
@himdel
Execution environment form fixups (ansible#4457)
176c5ac 
* LabelGroup from patternfly react-core 388ec1200

No-Issue

* EE fixups

* LabelGroup - import from patternfly-wrappers, move chipGroupProps there

* fixup translation - needs to happen later than class build time

(cherry picked from commit 37b9afe)
himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Oct 31, 2023
@himdel
Execution environment form fixups (ansible#4457)
da1ec05 
* LabelGroup from patternfly react-core 388ec1200

No-Issue

* EE fixups

* LabelGroup - import from patternfly-wrappers, move chipGroupProps there

* fixup translation - needs to happen later than class build time

(cherry picked from commit 37b9afe)
This was referenced Oct 31, 2023
Merged
Merged
himdel added a commit that referenced this pull request Oct 31, 2023
@himdel
Execution environment form fixups (#4457) (#4462)
347630c 
* LabelGroup from patternfly react-core 388ec1200

No-Issue

* EE fixups

* LabelGroup - import from patternfly-wrappers, move chipGroupProps there

* fixup translation - needs to happen later than class build time

(cherry picked from commit 37b9afe)
@github-actions github-actions bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Oct 31, 2023
himdel added a commit that referenced this pull request Oct 31, 2023
@himdel
Execution environment form fixups (#4457) (#4463)
3447176 
* LabelGroup from patternfly react-core 388ec1200

No-Issue

* EE fixups

* LabelGroup - import from patternfly-wrappers, move chipGroupProps there

* fixup translation - needs to happen later than class build time

(cherry picked from commit 37b9afe)
@github-actions github-actions bot added the backported-4.8 This PR has been backported to stable-4.8 (2.4) label Oct 31, 2023
@himdel himdel mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixocio nixocio nixocio approved these changes

Assignees
No one assigned
Labels
backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) backported-4.8 This PR has been backported to stable-4.8 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himdel @nixocio