Execution Environment add or edit

[MilanPospisil]

No description provided.

[AlexSCorey]

Milan and I discussed these changes off line. This is a great start. Let make some changes to help all AAP UI projects unify around some conventions.

[nixocio]

@MilanPospisil I got the latest version locally, and it seems to be working as expected.

Good job.

[AlexSCorey]

Just update that 1 string and I think we will be good to go.

[himdel]

The problem where clicking on the "Show less" button in the LabelGroup causes a reload is unrelated to this PR, that's a patternfly bug:

• LabelGroup renders items as <Label ..., and the last one as <Label isOverflowLabel ...,
• Label renders a <span> .. except with isOverflowLabel where it renders a <button>
• <button> inside <form> submits the form

The problem is that pattenrfly Label renders a raw <button> (which submits forms) instead of a <button type="button"> (which doesn't).

So, the solution is to fix patternfly, either of these works:

diff --git a/packages/react-core/src/components/Label/Label.tsx b/packages/react-core/src/components/Label/Label.tsx
index 0bab0335a..101b5c894 100644
--- a/packages/react-core/src/components/Label/Label.tsx
+++ b/packages/react-core/src/components/Label/Label.tsx
@@ -180,7 +180,8 @@ export const Label: React.FunctionComponent<LabelProps> = ({
     }
   };
 
-  const LabelComponent = (isOverflowLabel ? 'button' : 'span') as any;
+  const safeButton = ({ children, ...props }) => <button type="button" {...props}>{children}</button>;
+  const LabelComponent = (isOverflowLabel ? safeButton : 'span') as any;
 
   const button = closeBtn ? (
     closeBtn

OR

diff --git a/packages/react-core/src/components/LabelGroup/LabelGroup.tsx b/packages/react-core/src/components/LabelGroup/LabelGroup.tsx
index 82e8d0376..ba449b3d9 100644
--- a/packages/react-core/src/components/LabelGroup/LabelGroup.tsx
+++ b/packages/react-core/src/components/LabelGroup/LabelGroup.tsx
@@ -104,7 +104,9 @@ export class LabelGroup extends React.Component<LabelGroupProps, LabelGroupState
     });
   }
 
-  toggleCollapse = () => {
+  toggleCollapse = (e) => {
+    e.preventDefault();
+
     this.setState(prevState => ({
       isOpen: !prevState.isOpen,
       isTooltipVisible: Boolean(

(not sure how that interacts with the pf5 switch)

[nixocio]

@MilanPospisil informed that will the last framework changes in a follow up PR.

[AlexSCorey]

Looks good. All of my concerns have been addressed. Well done!