Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

master #111

Closed
wants to merge 22 commits into from
Closed

master #111

wants to merge 22 commits into from

Conversation

oatakan
Copy link

@oatakan oatakan commented Feb 9, 2017

@tima updated the pull request removing commits for vagrant

…he total deployment greatly. For 60 instances, down from 2 hours to 17 minutes.
@tima
Copy link
Collaborator

tima commented Feb 10, 2017

@SumerLI Appreciate the work. Can you please split bbb60c7 out of this PR and resubmit? I'm OK with that commit to improve the speed of the AWS provisioner. The other vagrant related commits is not an option we want to pursue now especially for classroom labs that I'd like to hold on that for later review.

@oatakan
Copy link
Author

oatakan commented Feb 14, 2017

@tima made the change you requested on the PR. thanks.

@samdoran
Copy link
Contributor

samdoran commented Mar 5, 2017

@SumerLI What's the purpose of the until loops added to several tasks?

@oatakan
Copy link
Author

oatakan commented Mar 6, 2017

@samdoran I had some jobs failed during yum update potentially due to network connection issues. This was a transient issue though.

@juliedavila
Copy link
Contributor

Now there's just merge conflicts

@juliedavila
Copy link
Contributor

@oatakan for the intermittent network issues, I've seen this before on AWS and have been able to consistently not get 404's etc if I restart network services before trying to do any kind of internet-based network action (like yum). Have you tried doing this?

@oatakan
Copy link
Author

oatakan commented Apr 23, 2017

@defionscode I will try that next time. Anything I can do to help move this PR move forward?

@juliedavila
Copy link
Contributor

@oatakan well right now the issue is merge conflicts if we can get those resolved then we can properly test

@tima
Copy link
Collaborator

tima commented May 8, 2017

The real holdup with merging PR (even if all of the conflicts were resolved) and PR #128 is that we need to do an extensive refactor of the lab provisioner "yesterday." In that context, enhancing what's there now seems like unnecessary effort.

@tima
Copy link
Collaborator

tima commented Jul 18, 2017

@oatakan I'm going to close this PR because it's gone way past it's original intent since it is linked to your master and all of your commits to it are being posted to this thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants