-
Notifications
You must be signed in to change notification settings - Fork 305
Conversation
…he total deployment greatly. For 60 instances, down from 2 hours to 17 minutes.
@SumerLI Appreciate the work. Can you please split bbb60c7 out of this PR and resubmit? I'm OK with that commit to improve the speed of the AWS provisioner. The other vagrant related commits is not an option we want to pursue now especially for classroom labs that I'd like to hold on that for later review. |
@tima made the change you requested on the PR. thanks. |
@SumerLI What's the purpose of the |
@samdoran I had some jobs failed during yum update potentially due to network connection issues. This was a transient issue though. |
Now there's just merge conflicts |
@oatakan for the intermittent network issues, I've seen this before on AWS and have been able to consistently not get 404's etc if I restart network services before trying to do any kind of internet-based network action (like yum). Have you tried doing this? |
@defionscode I will try that next time. Anything I can do to help move this PR move forward? |
@oatakan well right now the issue is merge conflicts if we can get those resolved then we can properly test |
The real holdup with merging PR (even if all of the conflicts were resolved) and PR #128 is that we need to do an extensive refactor of the lab provisioner "yesterday." In that context, enhancing what's there now seems like unnecessary effort. |
@oatakan I'm going to close this PR because it's gone way past it's original intent since it is linked to your master and all of your commits to it are being posted to this thread. |
@tima updated the pull request removing commits for vagrant