[WIP] Make generate-ansible-collection die on version mismatch #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ config-check SUCCESS in 33s |
tremble
suggested changes
Sep 13, 2022
| @@ -15,7 +15,7 @@ | |||
| - name: Generate version number for ansible collection | |||
| args: | |||
| chdir: "~/{{ item.src_dir }}" | |||
| shell: "if test -f 'galaxy.yml'; then ~/.local/bin/generate-ansible-collection; fi" | |||
| shell: "if test -f 'galaxy.yml'; then ~/.local/bin/generate-ansible-collection --for-release; fi" | |||
There was a problem hiding this comment.
build-ansible-collection is also run for 'normal' CI jobs, not just for the 'release' job, I think the --for-release flag should only be run if we're running because someone triggered a the job by pushing a tag
There was a problem hiding this comment.
Hmm, that totally makes sense, but I have no idea how to detect that situation :)
There was a problem hiding this comment.
I guess I'd need to copy this directory to a new one build-ansible-collection-for-release and do the change there. Or is there a cleaner way to do this @goneri?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on ansible-network/releases#23.