Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make generate-ansible-collection die on version mismatch #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Make generate-ansible-collection die on version mismatch #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playbooks/build-ansible-collection/run.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- name: Generate version number for ansible collection
args:
chdir: "~/{{ item.src_dir }}"
shell: "if test -f 'galaxy.yml'; then ~/.local/bin/generate-ansible-collection; fi"
shell: "if test -f 'galaxy.yml'; then ~/.local/bin/generate-ansible-collection --for-release; fi"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-ansible-collection is also run for 'normal' CI jobs, not just for the 'release' job, I think the --for-release flag should only be run if we're running because someone triggered a the job by pushing a tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that totally makes sense, but I have no idea how to detect that situation :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'd need to copy this directory to a new one build-ansible-collection-for-release and do the change there. Or is there a cleaner way to do this @goneri?

with_items: "{{ zuul.projects.values() | list }}"

- name: Create a directory the zuul-output
Expand Down