-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHORE: Use f-string instead of format #5272
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to leverage the following snippet "'\" some string \"'"
? I think it would be easier to read with '" some string "'
. I'm asking because it is appearing in multiple places and it is hard to read in some cases
# Conflicts: # _unittest_solvers/test_26_emit.py
# Conflicts: # doc/source/Resources/pyaedt_installer_from_aedt.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5272 +/- ##
==========================================
+ Coverage 83.28% 83.34% +0.06%
==========================================
Files 143 143
Lines 59151 59151
==========================================
+ Hits 49261 49299 +38
+ Misses 9890 9852 -38 |
# Conflicts: # src/ansys/aedt/core/filtersolutions_core/dll_interface.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this HUGEEEEEE refactoring, it will help a lot with future maintenance !
I found some typos that need to be adressed (one seem to be already here before your chagnes but I might be wrong).
Also, why did you perform extra changes in the tests (not only related to f-string formating) ?
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
For more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmalinve I reviewed only first 50 files! By the way, very impressive you went through all of these files! If I have time, I'll look at the rest.
# Conflicts: # src/ansys/aedt/core/visualization/plot/matplotlib.py # src/ansys/aedt/core/visualization/post/solution_data.py
Co-authored-by: Abdun Nur <146203416+anur7@users.noreply.github.com>
… chore/remove_format_string
The expected behavior of this method is not clean enough and the changes cause an issue with flake8. Let us leave this as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmalinve finished to review! Good job :)
No description provided.