Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: New class ReportPlotter to handle all matplotlib plot #5297

Merged
merged 26 commits into from
Oct 18, 2024

Conversation

maxcapodi78
Copy link
Collaborator

New class to handle all matplotlib methods and options

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Oct 15, 2024
@maxcapodi78 maxcapodi78 changed the title New class ReportPlotter to handle all matplotlib plot FEAT: New class ReportPlotter to handle all matplotlib plot Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 85.06944% with 129 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (d305939) to head (693b626).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5297      +/-   ##
==========================================
+ Coverage   83.26%   83.28%   +0.02%     
==========================================
  Files         143      143              
  Lines       58472    59151     +679     
==========================================
+ Hits        48684    49262     +578     
- Misses       9788     9889     +101     

@gmalinve
Copy link
Contributor

@maxcapodi78 @Samuelopez-ansys please avoid using .format() in strings. I just refactor all the occurrences in order to be compatible with f-string. (#5272).

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a game changer

@Samuelopez-ansys Samuelopez-ansys merged commit 384b892 into main Oct 18, 2024
41 of 42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/matplotlib_class branch October 18, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants