Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Improve extensions quality #5549

Merged
merged 48 commits into from
Dec 12, 2024
Merged

FEAT: Improve extensions quality #5549

merged 48 commits into from
Dec 12, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Dec 9, 2024

Description

Add documentation of extensions
Unify UI style

Issue linked

Close #5545

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.29%. Comparing base (4ab7475) to head (bcaa60a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5549      +/-   ##
==========================================
+ Coverage   85.00%   85.29%   +0.28%     
==========================================
  Files         151      151              
  Lines       60761    60753       -8     
==========================================
+ Hits        51652    51820     +168     
+ Misses       9109     8933     -176     

SMoraisAnsys
SMoraisAnsys previously approved these changes Dec 10, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the documentation and unifying the extensions. Also, I like the added checks in the workflows !

doc/source/User_guide/extensions.rst Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft December 10, 2024 08:24
@Samuelopez-ansys
Copy link
Member Author

I moved it to draft because the same had to be applied to more files, and I am still fixing the other extensions.

I have also uncommented the unit tests that were failing due to PyEDB issues, and now they are passing :) so we can improve the coverage.

@SMoraisAnsys
Copy link
Collaborator

I moved it to draft because the same had to be applied to more files, and I am still fixing the other extensions.

I have also uncommented the unit tests that were failing due to PyEDB issues, and now they are passing :) so we can improve the coverage.

I think this problem were related to the dotnet issues that was fixed two weeks ago. I'll add the same changes in PyAEDT.

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review December 10, 2024 11:25
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) December 10, 2024 12:34
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samuelopez-ansys first review of the doc (without code review)

@gmalinve gmalinve merged commit 3735ef4 into main Dec 12, 2024
42 checks passed
@gmalinve gmalinve deleted the feat/issue_5545 branch December 12, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update extension style
4 participants