-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Improve extensions quality #5549
Conversation
Improve coverage import_schematic
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5549 +/- ##
==========================================
+ Coverage 85.00% 85.29% +0.28%
==========================================
Files 151 151
Lines 60761 60753 -8
==========================================
+ Hits 51652 51820 +168
+ Misses 9109 8933 -176 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for improving the documentation and unifying the extensions. Also, I like the added checks in the workflows !
Add theme to UI
I moved it to draft because the same had to be applied to more files, and I am still fixing the other extensions. I have also uncommented the unit tests that were failing due to PyEDB issues, and now they are passing :) so we can improve the coverage. |
I think this problem were related to the dotnet issues that was fixed two weeks ago. I'll add the same changes in PyAEDT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samuelopez-ansys first review of the doc (without code review)
doc/source/User_guide/pyaedt_extensions_doc/hfss/choke_designer.rst
Outdated
Show resolved
Hide resolved
doc/source/User_guide/pyaedt_extensions_doc/hfss3dlayout/cutout.rst
Outdated
Show resolved
Hide resolved
doc/source/User_guide/pyaedt_extensions_doc/project/import_nastran.rst
Outdated
Show resolved
Hide resolved
doc/source/User_guide/pyaedt_extensions_doc/twinbuilder/convert_to_circuit.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
…t.rst Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
Description
Add documentation of extensions
Unify UI style
Issue linked
Close #5545
Checklist