Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Allow Optimetrics multi goals #5583

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Dec 17, 2024

Description

Optimetrics module was not allowing multiple goal definition.
Optimetrics objects was not consistent when new setup created by pyaedt and existing one.

Issue linked

#5564

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) December 17, 2024 10:30
@github-actions github-actions bot added the bug Something isn't working label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 85.29%. Comparing base (a68479b) to head (487b616).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5583      +/-   ##
==========================================
- Coverage   85.30%   85.29%   -0.01%     
==========================================
  Files         152      152              
  Lines       60868    60906      +38     
==========================================
+ Hits        51923    51950      +27     
- Misses       8945     8956      +11     

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit c10d896 into main Dec 17, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_optimetrics_goals branch December 17, 2024 15:16
@Samuelopez-ansys Samuelopez-ansys mentioned this pull request Dec 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants