-
Notifications
You must be signed in to change notification settings - Fork 8
DOC: legal process to perform a public release of a PyAnsys library #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6b716d
to
a5dea77
Compare
This is taking a bit more than expected but the results are looking really good. I am really taking care of the layout and structure so this is presented in a clean way to readers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's looking good! Mostly editorial comments. I'll leave it approved, pending the resolution of my comments
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's great.
It looks like there are some issues in the build process. Can you look into them before merging @jorgepiloto? |
I think it would be nice to include a documentation review inside the technical part of the process. I am not talking about documentation guidelines but quality. This is something @pyansys/documentation team should perform. |
Agreed, it should be a must. |
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Fix #232. This pull-request improves the section regarding the legal process required to perform a public release of a PyAnsys library. The following modifications were made: