fix: Remove pdf2image, add in pint as it's imported to the tests #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dnwillia-work
commented
Feb 19, 2025
•
dnwillia-work
commented
- Not even sure why this pdf2image dependency is there.
- pint is needed for some marked developer tests to run so added it to the test dependencies. Running the tests locally on the command line or in VS code fails.
dnwillia-work
changed the title
mkundu1
approved these changes
Feb 19, 2025
seanpearsonuk
approved these changes
Feb 19, 2025
|
@dnwillia-work @seanpearsonuk @mkundu1 pdf2image is required for cheat sheet generation. We have it in PyFluent as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.