Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove pdf2image, add in pint as it's imported to the tests #332

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix: Remove pdf2image, add in pint as it's imported to the tests #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5185e3
Remove pdf2image, add in pint as it's imported to the tests
dnwillia-work Feb 19, 2025
e0bff2d
Update to latest pint release
dnwillia-work Feb 19, 2025
5a824a9
Passing pint Quantity to pytest.approx not working
dnwillia-work Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ classifiers = [

dependencies = [
"importlib-metadata>=4.0",
"pdf2image>=1.17.0",
"pyyaml>=6.0",
]

Expand All @@ -44,6 +43,7 @@ tests = [
"pytest==8.3.4",
"pytest-cov==6.0.0",
"pytest-mock==3.14.0",
"pint==0.24.4",
]
lists = [
"numpy==2.2.2",
Expand Down
4 changes: 2 additions & 2 deletions tests/lib_compare/test_angle_units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ def test_pint_conversion_between_Hz_and_rps_and_radians_per_second():
)
radians_per_second = hz.to(ur.radian / ur.s)
assert_rightly_but_fail(
2.0 * math.pi * pint_value(hz) == pytest.approx(radians_per_second),
2.0 * math.pi * pint_value(hz) == pytest.approx(radians_per_second.magnitude),
"2 pi factor for Hz and rad/s",
)
assert_wrongly(
pint_value(hz) == pytest.approx(radians_per_second),
pint_value(hz) == pytest.approx(radians_per_second.magnitude),
"equivalence of Hz and rad/s",
)
# The problem is: one radian is asserted to be unity
Expand Down