Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Namespace match type to Self in antrea network policy doc. #3092

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

Jexf
Copy link
Member

@Jexf Jexf commented Dec 6, 2021

update Namespace match type to Self in antrea network policy doc.

Fixes: #3091

Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io

Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
@codecov-commenter
Copy link

Codecov Report

Merging #3092 (16bbf8e) into main (0a60d73) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
+ Coverage   40.07%   40.08%   +0.01%     
==========================================
  Files         166      166              
  Lines       20818    20818              
==========================================
+ Hits         8342     8345       +3     
+ Misses      11658    11656       -2     
+ Partials      818      817       -1     
Flag Coverage Δ
unit-tests 40.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 61.53% <0.00%> (-3.85%) ⬇️
pkg/apiserver/storage/ram/store.go 76.86% <0.00%> (-1.50%) ⬇️
pkg/agent/openflow/pipeline.go 21.28% <0.00%> (+0.06%) ⬆️
pkg/apiserver/certificate/certificate.go 76.71% <0.00%> (+6.84%) ⬆️

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas
Copy link
Contributor

@Jexf would you mind cherry-picking this to release-1.1, release-1.2, release-1.3 and release-1.4?
See https://github.com/antrea-io/antrea/blob/main/docs/contributors/cherry-picks.md

@antoninbas antoninbas merged commit 318d2a8 into antrea-io:main Dec 6, 2021
@Jexf
Copy link
Member Author

Jexf commented Dec 7, 2021

@antoninbas Of course not, I will cherry pick this mr to release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selfAction in ACNP is not working well, need update to Self
3 participants