Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify doc: featureGate setup for AntreaIPAM #4665

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Conversation

panpan0000
Copy link
Contributor

@panpan0000 panpan0000 commented Mar 1, 2023

relocation of PR of antrea-io/website#40

  • 1 .To fix : original doc tells the featureGate and conf in a bit confusing deployment, but actually, it's inside configmap antrea-config.

    1. To enhance: provides helm --set values when people install antrea by helm.

PS: I've tested the --set command and ensure it works.
image

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@panpan0000
Copy link
Contributor Author

/assign @tnqn

docs/antrea-ipam.md Outdated Show resolved Hide resolved
docs/antrea-ipam.md Outdated Show resolved Hide resolved
docs/antrea-ipam.md Show resolved Hide resolved
docs/antrea-ipam.md Outdated Show resolved Hide resolved
docs/antrea-ipam.md Outdated Show resolved Hide resolved
@panpan0000
Copy link
Contributor Author

Can you please help to review the second commit ? Thank!

docs/antrea-ipam.md Outdated Show resolved Hide resolved
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Mar 1, 2023

/skip-all

@tnqn tnqn merged commit dfbfa41 into antrea-io:main Mar 1, 2023
jainpulkit22 pushed a commit to urharshitha/antrea that referenced this pull request Apr 28, 2023
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants