featureGate in Configmap instead of Deployment. And add helm value #40
Conversation
✅ Deploy Preview for gracious-lamport-f690a0 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
@panpan0000 thank you for the PR. However, the content in the website repo is mirrored from the antrea repo: https://github.com/antrea-io/antrea/blob/main/docs/antrea-ipam.md. Changes made to website directly would be overwriten, could you open a PR to https://github.com/antrea-io/antrea instead?
And
website/content/docs/main/docs/antrea-l7-network-policy.md
Lines 53 to 57 in 35f5edd
| configuration parameter of `antrea-agent` to `true`. when antrea was installed | ||
| by helm, just simplily modify the helm chart `values.yaml` to set: |
There was a problem hiding this comment.
| configuration parameter of `antrea-agent` to `true`. when antrea was installed | |
| by helm, just simplily modify the helm chart `values.yaml` to set: | |
| configuration parameter of `antrea-agent` to `true`. When Antrea is installed | |
| by helm, just simply modify the helm chart `values.yaml` to set: |
| configuration parameter of `antrea-agent` to `true`. when antrea was installed | ||
| by helm, just simplily modify the helm chart `values.yaml` to set: | ||
| - `enableBridgingMode: true` | ||
| - `featureGates: {AntreaIPAM}` |
There was a problem hiding this comment.
I think the values need to be a map: {AntreaIPAM: true}
| - `featureGates: {AntreaIPAM}` | ||
| - `trafficEncapMode: "noEncap"` | ||
| - `noSNAT: true` | ||
| Failed to validate: failed to validate AntreaIPAM config: Bridging mode requires noSNAT |
| @@ -88,8 +88,14 @@ IPPool annotation, or when the `AntreaIPAM` feature is disabled. | |||
|
|
|||
| To enable flexible IPAM, you need to enable the `AntreaIPAM` feature gate for | |||
| both `antrea-controller` and `antrea-agent`, and set the `enableBridgingMode` | |||
| configuration parameter of `antrea-agent` to `true`. The needed changes in the | |||
| Antrea deployment YAML are: | |||
There was a problem hiding this comment.
"the Antrea deployment YAML" here means the manifest YAML used to deploy Antrea, not the antrea-controller deployment resource. But it's good to make it more specific.
| - `trafficEncapMode: "noEncap"` | ||
| - `noSNAT: true` | ||
| Failed to validate: failed to validate AntreaIPAM config: Bridging mode requires noSNAT | ||
| Otherwise, the needed changes in the Antrea configmap `antrea-config` YAML are: |
There was a problem hiding this comment.
| Otherwise, the needed changes in the Antrea configmap `antrea-config` YAML are: | |
| Otherwise, the needed changes in the Antrea ConfigMap `antrea-config` are: |
|
|
||
|
|
panpan0000
force-pushed
the
main
branch
2 times, most recently
from
2756d2a to
fe97541
Compare
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Thank you @tnqn , move PR to antrea-io/antrea#4665 |
To fix : original doc tells the featureGate and conf in deployment, but actually, it's inside configmap
antrea-config.To enhance: provides helm --set values when people install antrea by helm.