Run conformance tests for Arm images in this repo #6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
reviewed
Nov 19, 2024
luolanzone
reviewed
Nov 20, 2024
.github/workflows/conformance.yml
Outdated
Comment on lines
39
to
48
| description: The Github runner to use for the workflow | ||
| default: ubuntu-latest | ||
| antrea-image-platform: | ||
| description: Platform argument to provide when building the Antrea images | ||
| default: "linux/amd64" |
There was a problem hiding this comment.
Can these two be type: choice? So we don't have to figure what's other valid options if we want to run the conformance test manually with non-default values.
| token: ${{ secrets.ANTREA_BUILD_INFRA_WORKFLOW_DISPATCH_PAT }} | ||
| inputs: ${{ format('{{ "antrea-repository":"antrea-io/antrea", "antrea-ref":"{0}", "docker-tag":"{1}" }}', github.ref, env.DOCKER_TAG) }} | ||
| workflow: .github/workflows/conformance.yml | ||
| inputs: ${{ format('{{ "antrea-version":"{0}", "antrea-image-distro":"ubuntu", "test-suite":"conformance", "runner":"{1}", "antrea-image-platform":"{2}", "always-upload-logs":true }}', github.ref, matrix.runner, matrix.platform) }} |
There was a problem hiding this comment.
We can update the kind version to 0.25 as well. Since the default conformance test without given K8s version will use the default one as the kind's default. Now we are still using kind 0.23 and the conformance test image be 1.30 instead of 1.31.2.
There was a problem hiding this comment.
I will leave that to a future PR, given that ci/kind/version should be updated and it will affect other workflows
This is a follow-up to antrea-io#6486, which added support for building Antrea Arm images in the antrea-io/antrea repo, using Github-hosted Arm runners. With this change, we will also be testing Arm images in this repo, hence finishing to remove our dependency on a private reposiotry, with self-hosted runners (vmware-tanzu/antrea-build-infra). This change is very small, as we re-use the existing conformance.yml workflow, and add a dispatch step to the build.yml and build_tag.yml workflows (same repo dispatch, instead of dispatching to vmware-tanzu/antrea-build-infra, as was the case previously). Using Sonobuoy, we run the conformance test suite every time the main branch is updated, as well as for every release. Unfortunately, we have to re-build the image before running the tests, but thanks to caching it only represents a small amount of time. We also remove some deprecated maintainer documentation. Fixes antrea-io#6453 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
force-pushed
the
run-conformance-tests-for-arm-images-in-this-repo
branch
from
40d170d to
7049fa0
Compare
tnqn
approved these changes
Nov 21, 2024
antoninbas
deleted the
run-conformance-tests-for-arm-images-in-this-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6486, which added support for building Antrea Arm images in the antrea-io/antrea repo, using Github-hosted Arm runners.
With this change, we will also be testing Arm images in this repo, hence finishing to remove our dependency on a private reposiotry, with self-hosted runners (vmware-tanzu/antrea-build-infra).
This change is very small, as we re-use the existing conformance.yml workflow, and add a dispatch step to the build.yml and build_tag.yml workflows (same repo dispatch, instead of dispatching to vmware-tanzu/antrea-build-infra, as was the case previously). Using Sonobuoy, we run the conformance test suite every time the main branch is updated, as well as for every release. Unfortunately, we have to re-build the image before running the tests, but thanks to caching it only represents a small amount of time.
We also remove some deprecated maintainer documentation.
Fixes #6453