Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run conformance tests for Arm images in this repo #6818

Merged
merged 2 commits into from
Nov 21, 2024
+33 −56
Merged

Run conformance tests for Arm images in this repo #6818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580f7ab
Run conformance tests for Arm images in this repo
antoninbas Nov 18, 2024
7049fa0
Change antrea-image-platform input to 'choice'
antoninbas Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ jobs:
docker tag antrea/antrea-agent-ubuntu:"${DOCKER_TAG}" antrea/antrea-agent-ubuntu-${{ matrix.suffix }}:"${DOCKER_TAG}"
docker push antrea/antrea-controller-ubuntu-${{ matrix.suffix }}:"${DOCKER_TAG}"
docker push antrea/antrea-agent-ubuntu-${{ matrix.suffix }}:"${DOCKER_TAG}"
# Same repository workflow dispatch to run conformance tests
antoninbas marked this conversation as resolved.
Show resolved Hide resolved
- name: Run conformance tests
if: ${{ needs.check-env.outputs.push_needed == 'true' }}
uses: benc-uk/workflow-dispatch@v1
with:
workflow: .github/workflows/conformance.yml
inputs: ${{ format('{{ "antrea-version":"{0}", "antrea-image-distro":"ubuntu", "test-suite":"conformance", "runner":"{1}", "antrea-image-platform":"{2}" }}', github.sha, matrix.runner, matrix.platform) }}

push-manifest:
needs: [check-env, build]
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/build_tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,12 @@ jobs:
antrea/antrea-agent-ubuntu-arm:"${DOCKER_TAG}" \
antrea/antrea-agent-ubuntu-amd64:"${DOCKER_TAG}"
docker manifest push --purge antrea/antrea-agent-ubuntu:"${DOCKER_TAG}"
- name: Trigger Antrea arm tests
# Same repository workflow dispatch to run conformance tests
- name: Run conformance tests
uses: benc-uk/workflow-dispatch@v1
with:
repo: vmware-tanzu/antrea-build-infra
ref: refs/heads/main
workflow: Test Antrea ARM images
token: ${{ secrets.ANTREA_BUILD_INFRA_WORKFLOW_DISPATCH_PAT }}
inputs: ${{ format('{{ "antrea-repository":"antrea-io/antrea", "antrea-ref":"{0}", "docker-tag":"{1}" }}', github.ref, env.DOCKER_TAG) }}
workflow: .github/workflows/conformance.yml
inputs: ${{ format('{{ "antrea-version":"{0}", "antrea-image-distro":"ubuntu", "test-suite":"conformance", "runner":"{1}", "antrea-image-platform":"{2}", "always-upload-logs":true }}', github.ref, matrix.runner, matrix.platform) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the kind version to 0.25 as well. Since the default conformance test without given K8s version will use the default one as the kind's default. Now we are still using kind 0.23 and the conformance test image be 1.30 instead of 1.31.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave that to a future PR, given that ci/kind/version should be updated and it will affect other workflows


build-ubi:
runs-on: [ubuntu-latest]
Expand Down
28 changes: 22 additions & 6 deletions .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,24 @@ on:
description: Always upload logs regardless of the test result.
type: boolean
default: false
runner:
luolanzone marked this conversation as resolved.
Show resolved Hide resolved
description: The Github runner to use for the workflow
default: ubuntu-latest
antrea-image-platform:
description: Platform argument to provide when building the Antrea images
type: choice
options:
- "linux/amd64"
- "linux/arm64"
- "linux/arm/v7"
default: "linux/amd64"
required: true


jobs:
test:
name: Run tests
runs-on: [ubuntu-latest]
runs-on: ${{ inputs.runner }}
steps:
- name: Free disk space
# https://github.com/actions/virtual-environments/issues/709
Expand Down Expand Up @@ -70,13 +82,17 @@ jobs:
- name: Build Antrea image if required
if: ${{ steps.check-release.outputs.released == 'false' }}
run: |
./hack/build-antrea-linux-all.sh --pull --distro ${{ inputs.antrea-image-distro }}
- name: Install Kind
./hack/build-antrea-linux-all.sh --pull --distro ${{ inputs.antrea-image-distro }} --platform ${{ inputs.antrea-image-platform }}
- name: Get Kind version
id: get_kind_version
run: |
KIND_VERSION=$(head -n1 ./ci/kind/version || echo v0.23.0)
curl -Lo ./kind https://github.com/kubernetes-sigs/kind/releases/download/${KIND_VERSION}/kind-$(uname)-amd64
chmod +x ./kind
sudo mv kind /usr/local/bin
echo "kind_version=${KIND_VERSION}" >> $GITHUB_OUTPUT
- name: Install Kind
uses: helm/kind-action@v1
with:
version: ${{ steps.get_kind_version.outputs.kind_version }}
install_only: true
- name: Build local image for conformance test
if: ${{ inputs.k8s-version != '' }}
run: |
Expand Down
44 changes: 0 additions & 44 deletions docs/maintainers/antrea-docker-image.md
View file
Open in desktop

This file was deleted.

Loading