Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorect bbox with Infinity value for Container #407

Closed
1 task done
dengfuping opened this issue Feb 19, 2020 · 0 comments · Fixed by #408
Closed
1 task done

Incorect bbox with Infinity value for Container #407

dengfuping opened this issue Feb 19, 2020 · 0 comments · Fixed by #408

Comments

@dengfuping
Copy link
Member

dengfuping commented Feb 19, 2020 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  • See the log of console.

What is expected?

  • The bbox of group should be { x: 0, y: 0, minX: 0, minY: 0, maxX: 0, maxY: 0, width: 0, height: 0 } both.

What is actually happening?

  • The bbox of group should be { x: Infinity, y: Infinity, minX: Infinity, minY: Infinity, maxX: Infinity, maxY: Infinity, width: Infinity, height: Infinity } both.
Environment Info
g-canvas 0.3.20
System Mac OS
Browser Google Chrome 78.0.3904.70
dengfuping added a commit that referenced this issue Feb 19, 2020
@dengfuping
fix(g-base): bbox for container should not contain Infinity and -Infi…
f33f233 
…nity, close #407
@dengfuping dengfuping mentioned this issue Feb 19, 2020
Merged
14 tasks
@dengfuping dengfuping mentioned this issue Feb 19, 2020
Closed
1 task
dengfuping added a commit that referenced this issue Feb 24, 2020
@dengfuping
fix(g-base): bbox calculation should be correct for container, close #…
eaaf181 
…417 and #407
dengfuping added a commit that referenced this issue Feb 24, 2020
@dengfuping
fix(g-base): bbox calculation should be correct for container, close #…
5b7cb9e 
…417 and #407
@dengfuping dengfuping mentioned this issue Feb 24, 2020
Merged
14 tasks
dengfuping added a commit that referenced this issue Feb 24, 2020
@dengfuping
Merge pull request #420 from antvis/fix-issue-417
1871fc4 
fix(g-base): bbox calculation should be correct for container,  close #417 and #407
openwayne pushed a commit to openwayne/g that referenced this issue Jan 18, 2021
@dengfuping
fix(g-base): bbox for container should not contain Infinity and -Infi…
c91c89e 
…nity, close antvis#407
openwayne pushed a commit to openwayne/g that referenced this issue Jan 18, 2021
@dengfuping
fix(g-base): bbox calculation should be correct for container, close a…
ed81df3 
…ntvis#417 and antvis#407
openwayne pushed a commit to openwayne/g that referenced this issue Jan 18, 2021
@dengfuping
Merge pull request antvis#420 from antvis/fix-issue-417
42b6233 
fix(g-base): bbox calculation should be correct for container,  close antvis#417 and antvis#407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(g-base): bbox for container should not contain Infinity and -Infinity antvis/G
1 participant
@dengfuping