Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-base): bbox calculation should be correct for container, … #420

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Feb 24, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 🐞 [g-base] 修复 Container 的包围盒计算不正确的问题:
    • getBBox 和 getCanvasBBox 均为考虑不可见元素和空 group 的情况;
    • getBBox 的计算不应该受 matrix 影响;

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-base] Fix bbox calculation not correct for Container. #407 #417
🇨🇳 Chinese 🐞 [g-base] 修复 Container 的包围盒计算不正确的问题。#407 #417

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Feb 24, 2020
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Feb 24, 2020

Deploy preview for antv-g ready!

Built with commit db03060

https://deploy-preview-420--antv-g.netlify.com

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 24, 2020

This pull request introduces 4 alerts when merging 4be0f12 into 59b3b4f - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable

@dengfuping dengfuping merged commit 1871fc4 into master Feb 24, 2020
@dengfuping dengfuping deleted the fix-issue-417 branch February 24, 2020 14:44
@pr-triage pr-triage bot added the PR: merged label Feb 24, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 24, 2020

This pull request introduces 4 alerts when merging db03060 into 59b3b4f - view on LGTM.com

new alerts:

  • 4 for Useless assignment to local variable

openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-base): bbox calculation should be correct for container,  close antvis#417 and antvis#407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matrix 会影响 bbox 的计算
1 participant